Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts: remove duplicate functions #2357

Merged
merged 4 commits into from Jan 24, 2023
Merged

ts: remove duplicate functions #2357

merged 4 commits into from Jan 24, 2023

Conversation

Aursen
Copy link
Contributor

@Aursen Aursen commented Jan 9, 2023

No description provided.

@vercel
Copy link

vercel bot commented Jan 9, 2023

@Aursen is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@Aursen Aursen marked this pull request as ready for review January 11, 2023 09:41
@Henry-E
Copy link
Contributor

Henry-E commented Jan 17, 2023

So a bunch of these functions now exist on web3 but didn't exist there before?

@Henry-E
Copy link
Contributor

Henry-E commented Jan 23, 2023

i guess the question is

  • is the behavior still going to be the same for all of these functions in web3
  • is it a breaking change for anyone
  • is there anywhere else that the way these functions are being called needs to change?

1: I mean you're just deleting them so it will be up to anyone handling the migration to the web3 versions, if they use any different set of inputs?
2: ok, i see you've listed it as a breaking change in the changelog,

  • Maybe also note in the changelog that these functions are now available via the web3 library and that associated_address is now synchronous

3: I think that just deleting the functions + using typescript should have been enough to raise any compile errors if the functions were being used.

@Henry-E Henry-E merged commit 5f9b590 into coral-xyz:master Jan 24, 2023
@Aursen Aursen deleted the duplicate branch January 26, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants