Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spl: Update instructions and remove rent from constraints #2265

Merged
merged 4 commits into from Nov 19, 2022
Merged

spl: Update instructions and remove rent from constraints #2265

merged 4 commits into from Nov 19, 2022

Conversation

Aursen
Copy link
Contributor

@Aursen Aursen commented Nov 18, 2022 •
edited

Closes #1329, #963 and #1330

@vercel
Copy link

vercel bot commented Nov 18, 2022

@Aursen is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@Aursen Aursen changed the title spl: Update spl instructions and remove the Rent from constraints spl: Update spl instructions and remove the Rent from constraints (WIP) Nov 18, 2022
@Aursen Aursen marked this pull request as draft November 18, 2022 13:08
@Aursen Aursen changed the title spl: Update spl instructions and remove the Rent from constraints (WIP) spl: Update instructions and remove the Rent from constraints (WIP) Nov 18, 2022
@Aursen Aursen changed the title spl: Update instructions and remove the Rent from constraints (WIP) spl: Update instructions and remove rent from constraints Nov 18, 2022
@Aursen Aursen marked this pull request as ready for review November 18, 2022 14:14
@Henry-E
Copy link
Contributor

Henry-E commented Nov 19, 2022 •
edited

  • looks good
  • tests pass
  • it's a breaking change for some people but this is a strict improvement
  • removes rent sysvar from constraints and tests, which is possible now that we're using the newest spl-token create

It's a merge!

@Henry-E Henry-E merged commit 8ce18c3 into coral-xyz:master Nov 19, 2022
Henry-E pushed a commit to Henry-E/anchor that referenced this pull request Dec 6, 2022
@Aursen
spl: Update instructions and remove rent from constraints (coral-xyz#…
2b2db75 
…2265)

* Update spl instructions and remove the rent sys_var from constraints

* Fix initialize mint

* Update changelog and fix examples

* Remove oversights
@acheroncrypto acheroncrypto mentioned this pull request Nov 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spl: Add new token instructions that don't use rent sysvar
2 participants
@Aursen @Henry-E