feat: Use new canonical close account pattern #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Arrowana is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
Closed
|
@Arrowana does it make manual closing safe? |
|
@stegaBOB had a look and since the exit on Account does not do anything once the owner is no longer the program, it should be. |
Henry-E
pushed a commit
to Henry-E/anchor
that referenced
this pull request
Dec 6, 2022
yugure-orca
added a commit
to yugure-orca/whirlpools
that referenced
this pull request
Mar 13, 2023
- ProgramResult to Result<()>
- add /// CHECK comments
- remove space attribute on Mint account
- change create_metadata_accounts_v2 to v3
- update testcases
- Change in error code detected first
- Change in account closing method
coral-xyz/anchor#2169
yugure-orca
added a commit
to orca-so/whirlpools
that referenced
this pull request
Apr 7, 2023
## Anchor v0.26.0 upgrade (rebased) Special thanks @dovahcrow ! * anchor 0.26 solana 1.14.12 use mpl-token-metadata 1.7 because rust 1.60 does not compile 1.8 * initialize_pool: ignore passed bump and use one anchor derived - initialize_pool.test: update error codes, add a test case for ignoring bump * update expected error messages * add CHECK comments on UncheckedAccounts * use create_metadata_accounts_v3 (v2 have been deprecated) * update unit test cases (cargo test) ## Bundled Positions * import bundled positions * upgrade to Anchor v0.26.0 (position bundles related codes) - ProgramResult to Result<()> - add /// CHECK comments - remove space attribute on Mint account - change create_metadata_accounts_v2 to v3 - update testcases - Change in error code detected first - Change in account closing method coral-xyz/anchor#2169 * cargo fmt * update seed of BundledPosition * change temporary mint_authority to position_bundle * bump to v0.2.0 doc fields are added on IDL * fix: accidental failure test cases Fixed test cases that did not take into account rewards accruing up to just before the close. This test case is not related to bundled positions. The test case happened to fail, so I fixed them to make them all successful. --------- Co-authored-by: Weiyuan Wu <weiyuan@crows.land>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#604 but the light and clean way
Following the token program example
https://github.com/solana-labs/solana-program-library/blob/7c7507f4ec1f320bbc33af459d4d8b5573a6a906/token/program/src/processor.rs#L1022-L1027