Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spl: adding metadata account type #2014

Merged

Conversation

kevinrodriguez-io
Copy link
Contributor

Allows for proper usage of MetadataAccounts.

Example

#[account(
        seeds = [b"metadata", mpl_token_metadata::ID.as_ref(), mint.key().as_ref()],
        seeds::program = mpl_token_metadata::ID,
        bump,
        constraint = nft.uses.as_ref().map_or(false, |u| u.remaining > 0) @ AppError::NFTHasNoUses
)]
pub nft: Account<'info, MetadataAccount>

@vercel
Copy link

vercel bot commented Jun 29, 2022

@kevinrodriguez-io is attempting to deploy a commit to the 200ms Team on Vercel.

A member of the Team first needs to authorize it.

spl/src/metadata.rs Outdated Show resolved Hide resolved
spl/src/metadata.rs Outdated Show resolved Hide resolved
@kevinrodriguez-io
Copy link
Contributor Author

@armaniferrante @kklas Do you guys know what is that unrelated error in Tests / Core Tests?
Also the PR seem to be ready as per the new spec right @samuelvanderwaal ?

@kklas
Copy link
Contributor

kklas commented Jul 18, 2022

Seems like you have a linter error.

Run the following in the repo root directory

$ cargo fmt -- --check
$ cargo clippy --all-targets -- -D warnings
$ cargo test

@kevinrodriguez-io
Copy link
Contributor Author

@armaniferrante @kklas @kespinola @samuelvanderwaal Informally re-requesting review because the re-request button isn't working.

@callensm
Copy link
Member

callensm commented Aug 9, 2022

@kevinrodriguez-io rebase this branch from master to pull in the clippy error fixes and rerun the tests.

CHANGELOG.md Outdated Show resolved Hide resolved
@armaniferrante armaniferrante merged commit d3ee9b5 into coral-xyz:master Aug 13, 2022
yf-castel pushed a commit to castle-finance/anchor that referenced this pull request Aug 15, 2022
yf-castel pushed a commit to castle-finance/anchor that referenced this pull request Aug 15, 2022
Henry-E pushed a commit to Henry-E/anchor that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants