Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update changelog for 1426 #1432

Merged
merged 3 commits into from Feb 11, 2022

Conversation

paul-schaaf
Copy link
Contributor

#1426 may break some programs

@paul-schaaf
Copy link
Contributor Author

asking for review because Im not 100% sure it will break some programs

@paul-schaaf paul-schaaf changed the title docs: update changelog docs: update changelog for 1426 Feb 11, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@armaniferrante
Copy link
Member

asking for review because Im not 100% sure it will break some programs

It is technically a breaking change for those bold enough to depend on a module named __private.

@paul-schaaf
Copy link
Contributor Author

I meant code (as in lines of code) not codes btw :P

@paul-schaaf
Copy link
Contributor Author

paul-schaaf commented Feb 11, 2022

Id say technically breaking is breaking so we should add it

@armaniferrante
Copy link
Member

Id say technically breaking is breaking so we should add it

sgtm!

@paul-schaaf paul-schaaf merged commit d5e7e2a into coral-xyz:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants