Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: translateAddress should not rely on PublicKey constructor nam #1138

Merged
merged 5 commits into from Dec 15, 2021
Merged

fix: translateAddress should not rely on PublicKey constructor nam #1138

merged 5 commits into from Dec 15, 2021

Commits on Dec 15, 2021

  1. ts: fix translateAddress should not rely on PublicKey constructor name 

    Since anchor is used in web projects which will minify/mangle function
names, checking an input object for a custom constructor name is unsafe.

Moreover, checking the type of the input Address is unnecessary since
`PublicKey`'s constructor handles:
- `string`
- `array`
- object with a `{ _bn }` shape (like `PublicKey` itself)
    @0xCryptoSheik
    0xCryptoSheik committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    7712004 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/translate-address-no-constructor-name

    @paul-schaaf
    paul-schaaf committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    e4b28a9 View commit details
    Browse the repository at this point in the history

  3. docs: update changelog

    @paul-schaaf
    paul-schaaf committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    82a338d View commit details
    Browse the repository at this point in the history

  4. ts: adjust translateAddress to allow PublicKeys to pass through

    @paul-schaaf
    paul-schaaf committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    5ae4181 View commit details
    Browse the repository at this point in the history

  5. tests: update lock file

    @paul-schaaf
    paul-schaaf committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    98e0fb0 View commit details
    Browse the repository at this point in the history