Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async vs Sync RpcClient #2219

Closed
cavemanloverboy opened this issue Oct 9, 2022 · 4 comments
Closed

Async vs Sync RpcClient #2219

cavemanloverboy opened this issue Oct 9, 2022 · 4 comments
Labels
client enhancement New feature or request

Comments

@cavemanloverboy
Copy link
Contributor

By default, the .rpc() method of the anchor_client Program returns a blocking RpcClient. It would be great if we could have the option to request the async RpcClient via .async_rpc() perhaps. The async RpcClient is under a different module of the solana_client, which anchor_client already re-exports.

I have done this on my local fork but would like to see this upstream.
@Henry-E
Copy link
Contributor

Henry-E commented Dec 7, 2022

Happy to look at a PR

@Henry-E Henry-E added the enhancement New feature or request label Dec 7, 2022
@cavemanloverboy
Copy link
Contributor Author

I'll get you a PR this weekend

@cavemanloverboy cavemanloverboy mentioned this issue Dec 18, 2022
Merged
@cavemanloverboy
Copy link
Contributor Author

PR is at #2322

@acheroncrypto
Copy link
Collaborator

Added in #2322.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Henry-E @cavemanloverboy @acheroncrypto