Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add async_rpc method #2322

Merged
merged 3 commits into from Feb 6, 2023
Merged

add async_rpc method #2322

merged 3 commits into from Feb 6, 2023

Conversation

cavemanloverboy
Copy link
Contributor

@cavemanloverboy cavemanloverboy commented Dec 18, 2022

Addresses #2219

Adds a method which returns a nonblocking solana rpc client. This allows users to get a solana client that they can use with their own tokio (or other async) runtime instead of having solana_sdk internally create a single-threaded tokio runtime to run the nonblocking client methods on.

@vercel
Copy link

vercel bot commented Dec 18, 2022

@cavemanloverboy is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@Aursen
Copy link
Contributor

Aursen commented Dec 18, 2022

Is it better to put like a feature for asynchronous tasks in the client? It is rare to use async and sync together. And update event handler with Tokio maybe?

@Henry-E
Copy link
Contributor

Henry-E commented Dec 21, 2022

Same here, add an entry under the features heading in the changelog and we're good to merge

@Henry-E
Copy link
Contributor

Henry-E commented Feb 6, 2023

closes: #2219

@Henry-E Henry-E merged commit cd63049 into coral-xyz:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants