[declare] Warn on unused using attributes on sub-obligations #19007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coqbot-app
bot
added
the
needs: full CI
ejgallego
force-pushed
the
sub_obligations_using
branch
from
28cb580
to
e16a243
Compare
|
This doesn't seem to work well yet, not sure if worth it. |
herbelin
reviewed
May 14, 2024
Comment on lines
+2588
to
2591
| let () = warn_unused_using () ?loc:None in | ||
| let using = Internal.get_using prg in | ||
| let env = Global.env () in | ||
| let f {CInfo.name; typ; _} = name, [typ] in |
There was a problem hiding this comment.
The warning should be when using is non-None, and, then, the idea would be that the useless computation that follows is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #18890