New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for symlinks in cookiecutter templates #868
Conversation
This PR aims to tackle #865 |
Sorry for the noise here--don't have a Windows+Python 2.7 environment, so was letting AppVeyor test things for me. This fix generally works, but there is a complication: Windows+Python2.7 doesn't support symlinks out of the box. To make this work, I've added the I have a little work left to re-implement rmtree in a way that supports symlinks in Windows in the tests. Also, letting flake8 fail on the win_utils.py until we settle whether to use those versions of take the |
Finally got a Windows VM to develop against so could get symlinks working there. Separated out the posix and the Windows changes into separate commits so we can reason about them separately. For background, most concise summary of symlinks in Windows and Python <3.2 is here:
|
Can we merge this PR? - It fixes a problem that blocks my work, currently. I understand it's a bit large, mainly due to adding symlink support for Windows. If this is a problem can we get the PR merged earlier if we move the Windows-related changes to a separate PR? |
Frankly, symlinks on Windows feels rather artificial to me. I wouldn't know how to create them using the file manager or @hackebrot If the complexity that Windows introduces were removed in this PR would you be willing to merge this PR right away? |
@hackebrot Should the complexity of Windows be removed from this PR to make the decision of merging easier? |
Added just the PR for posix systems and newer Python, which is cleaner: #934 I'll create an issue for Windows with Python < 3.2, which we may end up won't fixing given the complexity it introduces. |
@pjbull, unfortunately, it was not reviewed in time. Currently, we are making cookiecooter issues and prs cleanup after some time without project maintenance. If you can adapt this code to currentl project code state it will be reviewed much faster again. |
@ssbarnea Please stop closing pull requests without any resolution. At least for problematic functions like symlinks. It is hard to find them again. And this problem not yet solved. |
non-rendered directories