New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.7 #2052
base: main
Are you sure you want to change the base?
Conversation
I think this is fine. @cookiecutter/cookie-monsters What do you think? |
great group name |
I'm 👍🏼 but I would like to test what happens with pipx in 3.7 trying to get the latest cookiecutter |
|
According to Semantic Versioning this is a major change, right? I would prefer to wait for a 3.0 release to introduce this. |
i'm not sure the spec says anything specifically about this case. I personally would not consider dropping support for an end of life minor release of the interpreter to be a major change a major change would imply downstream breakages. And you won't get downstream breakages because the specified min python version will mean that people using older interpreters will be effectively pinned at an older version of cookiecutter (someone please test that don't take my word for it) |
i don't think there's any rush to merge this. It's dead easy to keep rebasing. It really only becomes important once you want to use newer features, or you want to update the dependencies and those dependencies have dropped support for 3.7. I personally drop EOF python versions like a hot brick, but it would be perfectly reasonable to hold onto it until it's actually causing an issue and then pull the cord on this PR |
e10adc5
to
76cfb4f
Compare
b3b2f36
to
5260bce
Compare
drops support for python 3.7
python 3.7 is end of life