Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #2052

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danieleades
Copy link
Contributor

drops support for python 3.7
python 3.7 is end of life

@jensens
Copy link
Contributor

jensens commented Apr 4, 2024

I think this is fine. @cookiecutter/cookie-monsters What do you think?

@danieleades
Copy link
Contributor Author

I think this is fine. @cookiecutter/cookie-monsters What do you think?

great group name

@ericof ericof self-requested a review April 5, 2024 01:08
@ericof
Copy link
Member

ericof commented Apr 5, 2024

I'm 👍🏼 but I would like to test what happens with pipx in 3.7 trying to get the latest cookiecutter

@jensens
Copy link
Contributor

jensens commented Apr 5, 2024

I'm 👍🏼 but I would like to test what happens with pipx in 3.7 trying to get the latest cookiecutter

python_requires='>=3.8', in setup.cfg should prevent the combination of Python 3.7 and pip/pipx to use the newer version and fallback to a version with python_requires='>=3.7', set.

@jensens jensens changed the title drop support for python 3.7 Drop support for Python 3.7 Apr 5, 2024
@jensens jensens added the major Marks an important change, when major version update required label Apr 5, 2024
@jensens
Copy link
Contributor

jensens commented Apr 5, 2024

According to Semantic Versioning this is a major change, right? I would prefer to wait for a 3.0 release to introduce this.

@jensens jensens added this to the 3.0.0 milestone Apr 5, 2024
@danieleades
Copy link
Contributor Author

According to Semantic Versioning this is a major change, right? I would prefer to wait for a 3.0 release to introduce this.

i'm not sure the spec says anything specifically about this case. I personally would not consider dropping support for an end of life minor release of the interpreter to be a major change

a major change would imply downstream breakages. And you won't get downstream breakages because the specified min python version will mean that people using older interpreters will be effectively pinned at an older version of cookiecutter (someone please test that don't take my word for it)

@jensens jensens added enhancement This issue/PR relates to a feature request. and removed major Marks an important change, when major version update required labels Apr 5, 2024
@danieleades
Copy link
Contributor Author

i don't think there's any rush to merge this. It's dead easy to keep rebasing.

It really only becomes important once you want to use newer features, or you want to update the dependencies and those dependencies have dropped support for 3.7.

I personally drop EOF python versions like a hot brick, but it would be perfectly reasonable to hold onto it until it's actually causing an issue and then pull the cord on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants