git clone subprocess NO LONGER FAILS for SSH when key requires passphrase #1984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue described in #1653.
My solution here is to replace the subprocess.check_output() call with subprocess.run(), which allows the SSH passphrase prompt to be passed through to the user.
The subprocess.run() function is more flexible and can interact with the user when necessary, such as prompting for a passphrase.
In this revised function, subprocess.run is used with the check=False argument to avoid immediate failure. The return code and output are then manually checked and handled. This should allow the passphrase prompt to appear and be entered by the user.
I have tested this locally and passed all unit tests. Note, this change required me to modify some of the test cases. This is my process, which was done in a virtual environment:
pip install -e .
pip list
cookiecutter git+ssh://git@github.com/audreyr/cookiecutter-pypackage.git
Thus the issue/s are addressed.