feat: Pass errors from pre/post-gen hook(s) to the FailedHookException message #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 31, 2023 17:39
…xception message If cookiecutter functions are called in python code, it is useful to catch possible errors appearing during the execution of cookiecutter pre/post-generate hooks. modified: cookiecutter/hooks.py to: * catch possible errors from the subprocess calling hook scripts * add these errors in the FailedHookException message The change is not breaking, all tests run to 100% coverage Co-authored-by: vykozlov
modified: * ../.pre-commit-config.yaml : "gitlab.com/com/pycqa/flake8" => github.com/pycqa/flake8 as the repo at "gitlab.com" does not exist * hooks.py : to comply with pep8
Co-authored-by: Kurt McKee <contactme@kurtmckee.org>
ericof
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If cookiecutter functions are called in python code, it is useful to catch possible errors appearing during the execution of cookiecutter pre/post-generate hooks.
modified: cookiecutter/hooks.py to:
The change is not breaking, all tests run to 100% coverage
Co-authored-by: vykozlov