Pass the Jinja env to allow changing the variable_*_string values #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
att14
reviewed
Apr 26, 2022
| Fake Project | ||
| ============ | ||
|
|
||
| Blah!!!! |
There was a problem hiding this comment.
Why is this fake repo needed, it seems nearly identical to the first. What case is it covering that pre3 does not?
There was a problem hiding this comment.
the pre-existing test used 2 fake repos so I just replicated the same thing to show it works the same, I can remove one of them if it was unnecessary
Co-authored-by: Andrew Tribone <780132+att14@users.noreply.github.com>
|
I really need this feature, congrats! Hoping to be merged soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current master branch you can pass a dict to the variable "_jinja2_env_vars" to customize the Jinja Environment, among other things this allows you to change "variable_start_string" and "variable_end_string" which defaults to "{{" and "}}" respectively, however those were left as hard coded values in a couple of functions which prevented the usage of any other value for these 2 settings.