Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --directory in abbreviation definitions #1646

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

exhuma
Copy link

@exhuma exhuma commented Feb 9, 2022

This PR adds support to specify a "directory" in an abbreviation (as in the --directory CLI argument).

In order to support this while still being backwards compatible, the code needed a slight adaptation in how expansions are executed.

When this is merged, a user can write abbreviations in two variants:

  • simple: A simple string. This is the same behaviour as currently exists in cookie-cutter
  • advanced: A mapping. This new format allows to add the directory option.

This change also opens up the possibility to add more keys to abbreviations, opening up the doors to more advanced abbreviation handling, while still keeping backwards compatibility.

@exhuma
Copy link
Author

exhuma commented Oct 29, 2022

Updated with "main" again and the diff still looks clean. Any update/feedback on this?

@liortct
Copy link
Contributor

liortct commented Jan 21, 2023

Hi @exhuma

We started working on a new community fork of the Cookiecutter project, named Cookieninja.
The fork is found at: https://github.com/cookieninja-generator/cookieninja

We have re-opened and merged your PR in the Cookieninja project at: cookieninja-generator/cookieninja#64

We're trying to bring the life back to this amazing project.
We are committed to reviewing and merging each PR in up to 2 weeks from the day it's opened (if there are no issues with it).
We'd really like you to join the fork, star it and contribute to it!

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants