Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address doctests D103 #1354

Closed
wants to merge 42 commits into from
Closed

Address doctests D103 #1354

wants to merge 42 commits into from

Conversation

insspb
Copy link
Member

@insspb insspb commented Apr 14, 2020

Closes #1269
Closes #742

Feel free to check my english, while it is in wip.

@insspb insspb added the WIP Work In Progress label Apr 14, 2020
@insspb insspb self-assigned this Apr 14, 2020
@insspb insspb added this to In progress in 1.7.1 Release via automation Apr 14, 2020
@ssbarnea ssbarnea self-requested a review April 14, 2020 15:35
@ssbarnea
Copy link
Member

I think that you want to remove D103 exclude from setup.cfg with this change.

1.7.1 Release automation moved this from In progress to Reviewer approved Apr 14, 2020
@ssbarnea ssbarnea changed the title D103 Address doctests D103 Apr 14, 2020
@ssbarnea ssbarnea added documentation This issue/PR relates to or includes documentation. and removed WIP Work In Progress labels Apr 14, 2020
@insspb insspb marked this pull request as draft April 14, 2020 15:48
@insspb
Copy link
Member Author

insspb commented Apr 14, 2020

I think that you want to remove D103 exclude from setup.cfg with this change.

Want, but when will fixx all 100+ issues.
Converted to draft.

@insspb insspb requested a review from ssbarnea April 16, 2020 17:50
@insspb insspb marked this pull request as ready for review April 16, 2020 17:51
@insspb insspb added code style This issue/PR relates to the project code style modification tests This PR relates to tests, QA, CI. and removed documentation This issue/PR relates to or includes documentation. labels Apr 17, 2020
@insspb insspb added the needs-review PR Only: This PR require review from other developer label Apr 17, 2020
@insspb insspb moved this from Reviewer approved to Review in progress in 1.7.1 Release Apr 17, 2020
@pfmoore pfmoore removed their request for review April 17, 2020 07:01
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes added are good but there are issues that would prevent it from passing review:

  • that is a jumbo size review, I stopeed the review when I was only ~20% of it.
  • this change combines multiple changes unrelated to docstrings

Now is time to split it in several smaller ones that can easily be reviewed and merged. Please try to cherry pick similar changes counting up to ~100 lines per pull-request.

I will prioritize review of any such change so we can finish delivering this task.

Probably is better to not create all PRs in parallel because likely they will require more rebase work, i suspect serial would be easier for both in this case (once one merged, create a new one).

@insspb
Copy link
Member Author

insspb commented Apr 17, 2020

This PR is splited to:

#1369
#1370
#1371
#1372
#1373
#1374
#1375
#1376
#1377
#1378
#1379
#1380

@insspb insspb closed this Apr 17, 2020
1.7.1 Release automation moved this from Review in progress to Done Apr 17, 2020
@insspb
Copy link
Member Author

insspb commented Apr 17, 2020

Please do not touch branch, until other merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code style This issue/PR relates to the project code style modification needs-review PR Only: This PR require review from other developer tests This PR relates to tests, QA, CI.
Projects
No open projects
1.7.1 Release
  
Done
Development

Successfully merging this pull request may close these issues.

PEP257 docstrings compliance Run pep257 on each file to improve docstrings
2 participants