-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address doctests D103 #1354
Address doctests D103 #1354
Conversation
I think that you want to remove |
Want, but when will fixx all 100+ issues. |
…n setup/teardown fixture.
… docstrings update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes added are good but there are issues that would prevent it from passing review:
- that is a jumbo size review, I stopeed the review when I was only ~20% of it.
- this change combines multiple changes unrelated to docstrings
Now is time to split it in several smaller ones that can easily be reviewed and merged. Please try to cherry pick similar changes counting up to ~100 lines per pull-request.
I will prioritize review of any such change so we can finish delivering this task.
Probably is better to not create all PRs in parallel because likely they will require more rebase work, i suspect serial would be easier for both in this case (once one merged, create a new one).
Please do not touch branch, until other merged. |
Closes #1269
Closes #742
Feel free to check my english, while it is in wip.