-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: Support for multiple templates per repository #1224
Added: Support for multiple templates per repository #1224
Conversation
@insspb Should I also increment version in setup.py? |
No, unfortunately, we have a long new version deploy process, so you should not increment it, as until several core developers review this it is hard to say when it will be merged. (Last PRs merged fast, but we have some dev depth with opened PRs since 2017) |
Codecov Report
@@ Coverage Diff @@
## master #1224 +/- ##
==========================================
- Coverage 100% 99.87% -0.13%
==========================================
Files 18 18
Lines 784 789 +5
==========================================
+ Hits 784 788 +4
- Misses 0 1 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1224 +/- ##
======================================
Coverage 100% 100%
======================================
Files 18 18
Lines 784 788 +4
======================================
+ Hits 784 788 +4
Continue to review full report at Codecov.
|
@RomHartmann checked docs on local and get another errors after it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong PR accidentally approved. Waiting for my PR merge.
@insspb Approved PR. Don't know what the merge policy is in this project, so I'll fall back to least-permission and wait for you to merge it :) |
@RomHartmann you should merge my PR to your RomHartmann:1223-enable_repo_subdirectories repo. Then it will be available here automatically. Merge policy in cookiecutter: |
@michaeljoseph Any other change suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍
Howdy folks! Interested in having this available for a project. Looks like it's all good to go but just needs to be merged? |
Seconding @SteveHNH, this would be great to use in our current project! |
So excited for this feature to be merged! |
For issue #1223
cookiecutter.json
in a subdirectory. This was written to solve the problem that cookiecutter could not work with subdirectories within github. Also works with local, though that use case makes no sense :)