Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from watchgod to watchfiles #3791

Merged
merged 1 commit into from Jul 26, 2022
Merged

Switch from watchgod to watchfiles #3791

merged 1 commit into from Jul 26, 2022

Conversation

monosans
Copy link
Contributor

watchgod was renamed to watchfiles.

See README on PyPI.

browniebroke
browniebroke approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

{{cookiecutter.project_slug}}/requirements/local.txt
@@ -8,7 +8,7 @@ psycopg2==2.9.3 # https://github.com/psycopg/psycopg2
psycopg2-binary==2.9.3 # https://github.com/psycopg/psycopg2
{%- endif %}
{%- if cookiecutter.use_async == 'y' or cookiecutter.use_celery == 'y' %}
watchgod==0.8.2 # https://github.com/samuelcolvin/watchgod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask if we still need watchgod for uvicorn, but it looks like support for watchfiles was added in v0.18.0.

@browniebroke browniebroke merged commit 26eff14 into cookiecutter:master Jul 26, 2022
@browniebroke
Copy link
Member

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@browniebroke browniebroke browniebroke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@monosans @browniebroke