Base the bump calculation and changelog on current version #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the bump suggestion and changelog generation ignored the version discovered by the code and did their own base version discovery - often times getting it wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the bump suggestion and changelog generation ignored the version discovered by the code and did their own base version discovery - often times getting it wrong.
This PR requires Conventional Commit 777 or similar to be merged and deployed first, then the version of
conventional-recommended-bumpupdated to match the release that contains those changes. While this PR won't break if that's not done, it also won't gain the functionality I intended to bring.I'm not sure whether or not to consider this a breaking change. It might be as it changes what the recommended bump and changelog generation returns under some edge cases: specifically when the most recent tag in the commit history graph for the current commit is not the most recent release.
WRT testing: after doing a deep scan of how the testing system works here I also don't see a nice way to test the core problem, as the test mock system mocks the libraries, resulting in no ability to test the core problem: that the bump and changelog libraries weren't being fed the information they need to determine the correct base release tag.