Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add possibility to provide custom flags to commit fetcher #978

Merged
merged 2 commits into from
Apr 19, 2023
Merged

fix: add possibility to provide custom flags to commit fetcher #978

merged 2 commits into from
Apr 19, 2023

Conversation

cakeinpanic
Copy link
Contributor

@cakeinpanic cakeinpanic commented Apr 16, 2023 •
edited by dangreen

Providing a way to bypass this issue
closes #924

@cakeinpanic
Copy link
Contributor Author

@dangreen please take a look at this small change, it's minor non-breaking release which would unblock me a loooot :)

@dangreen dangreen self-requested a review April 17, 2023 08:53
@coveralls
Copy link

coveralls commented Apr 17, 2023 •
edited

Coverage Status

Coverage: 94.774% (+0.004%) from 94.77% when pulling 70c0334 on cakeinpanic:master into d0e5d59 on conventional-changelog:master.

dangreen
dangreen requested changes Apr 17, 2023
View reviewed changes
Copy link
Member

@dangreen dangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thank you for the contribution.

Could you please run pnpm fix to lint and fix possible lint issues?

packages/conventional-recommended-bump/index.js Outdated Show resolved Hide resolved
@cakeinpanic @dangreen
Update packages/conventional-recommended-bump/index.js
70c0334 
Co-authored-by: Dan Onoshko <danon0404@gmail.com>
@cakeinpanic
Copy link
Contributor Author

@dangreen please take a look now

@dangreen dangreen merged commit 58f0887 into conventional-changelog:master Apr 19, 2023
5 checks passed
@cakeinpanic
Copy link
Contributor Author

@dangreen please release a new version, I need to use these changes in our production :)

@dangreen
Copy link
Member

@bcoe Hello. Could you help with the release? What steps should we take?

@github-actions github-actions bot mentioned this pull request Jun 6, 2023
Merged
@dangreen
Copy link
Member

dangreen commented Jun 6, 2023

@cakeinpanic Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangreen dangreen dangreen approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[conventionalRecommendedBump] inconsistency in including merge commits
3 participants
@cakeinpanic @coveralls @dangreen