Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid config mutating with default params (fixes #930) #931

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: avoid config mutating with default params (fixes #930) #931

wants to merge 2 commits into from

Conversation

floydspace
Copy link

@floydspace floydspace commented Jul 2, 2022 •
edited

This PR fixes #930. Avoid mutating lerna.json with default changelogPreset params
image

It'd be wise to add no-param-reassign eslint rule and fix this code smell everywhere, but I'd rather like to ask your opinion about this guys.

Thank you.

@floydspace floydspace changed the title fix: avoid config mutating with default params fix: avoid config mutating with default params (fixes #930) Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conventionalcommits as changelogPreset in lerna.json leads to unwanted config update
1 participant
@floydspace