Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conventional-changelog-conventionalcommits: defaultConfig use immutable assign #906

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

conventional-changelog-conventionalcommits: defaultConfig use immutable assign #906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/conventional-changelog-conventionalcommits/writer-opts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ function getWriterOpts (config) {

// merge user set configuration with default configuration.
function defaultConfig (config) {
config = config || {}
config = Object.assign({}, config)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use spread here?

Suggested change
config = Object.assign({}, config)
function defaultConfig (originalConfig) {
const config = { ...originalConfig }

config.types = config.types || [
{ type: 'feat', section: 'Features' },
{ type: 'feature', section: 'Features' },
Expand Down