feat: full hash in commit.hbs for links #880
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the link to a commit to use the full hash instead of the shortened hash that is used in the link preview. see also: conventional-changelog#102 (comment)
|
@mrt181 is the reason for this that the |
|
Yes, the short hash does not work with bitbucket and azure DevOps for example |
|
@mrt181 this seems like a good fix 👌 but mind updating tests? |
|
|
@bcoe Those tests fail even when i revert my changes? |
depends on has shorten version is sometimes broken on github (tho i noticed it only 2 times on github enterprise) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the link to a commit to use the full hash instead of the shortened hash that is used in the link preview.
see also: #102 (comment)