Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conventional-changelog-conventionalcommits)!: use ## <small> for patch versions #868

Closed
wants to merge 2 commits into from
Closed

Conversation

shivjm
Copy link

@shivjm shivjm commented Nov 2, 2021

This is a backwards-incompatible change, so I would understand if it needed to be behind a configuration flag or something. I’ll leave it open pending feedback (or merging, of course!).

Closes #867

EDIT:
I got the tests running but they universally fail even on a clean upstream clone inside a Docker container, so I don’t think they’ll be much help here.

@languitar
Copy link

Would it also be an option to go in this direction regarding my comment at #867 (comment) ?

diff --git a/packages/conventional-changelog-conventionalcommits/templates/header.hbs b/packages/conventional-changelog-conventionalcommits/templates/header.hbs
index a4d6ec4..d7efc8f 100644
--- a/packages/conventional-changelog-conventionalcommits/templates/header.hbs
+++ b/packages/conventional-changelog-conventionalcommits/templates/header.hbs
@@ -1,8 +1,4 @@
-{{#if isPatch~}}
-  ###
-{{~else~}}
-  ##
-{{~/if}} {{#if @root.linkCompare~}}
+## {{#if @root.linkCompare~}}
   [{{version}}]({{compareUrlFormat}})
 {{~else}}
   {{~version}}

@shivjm
Copy link
Author

shivjm commented Jan 25, 2022

Sure. I used small to preserve the appearance like in #214, but since the element has its own semantics I’d be happier leaving it out.

@shivjm
Copy link
Author

shivjm commented May 28, 2022

I guess #920 supersedes this.

@shivjm shivjm closed this May 28, 2022
@shivjm shivjm deleted the use-small-for-patch-versions branch May 28, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

conventional-changelog-conventionalcommits: Patch version headings shouldn’t be a different size
2 participants