Ensure outputUnreleased resolved correctly given lernaPackage/tagPrefix #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrectly given lernaPackage/tagPrefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of
conventional-changelog-core@4.2.4,options.outputUnreleasedis erroneously set totruewhen using a custom tag prefix viatagPrefixorlernaPackage. This happens because the check that determinesoptions.outputUnreleased's value is hardcoded expecting"v" + versionwith no regard for custom tag prefixes.The result is extremely odd behavior when generating changelogs for monorepo packages. In this example, it repeats the entire changelog with the repeated entry using an invalid version. In this example, when used alongside
semantic-release—which can append the old changelog to the new—it repeats the second entry in the changelog twice. In this example, without usingsemantic-release, it repeats the top changelog entry; the top entry is empty because there are no "unreleased" commits in this example.This PR fixes this bug.