Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gulp-conventional-changelog): remove unnecessary object-assign polyfill #745

Closed
wants to merge 7 commits into from
Closed

refactor(gulp-conventional-changelog): remove unnecessary object-assign polyfill #745

wants to merge 7 commits into from

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Jan 17, 2021 •
edited

https://github.com/sindresorhus/object-assign

Node.js 4 and up, as well as every evergreen browser (Chrome, Edge, Firefox, Opera, Safari), support Object.assign() 馃帀. If you target only those environments, then by all means, use Object.assign() instead of this package.

#753

@armano2 armano2 changed the title fix: drop no longer needed object-assign and use Object.assign directly refactor: drop no longer needed object-assign and use Object.assign directly Jan 19, 2021
@armano2 armano2 changed the title refactor: drop no longer needed object-assign and use Object.assign directly refactor(gulp-conventional-changelog): remove unnecessary object-assign polyfill Jan 19, 2021
@armano2 armano2 mentioned this pull request Jan 22, 2021
Closed
9 tasks
@armano2 armano2 closed this Apr 14, 2023
@armano2
Copy link
Contributor Author

armano2 commented Apr 14, 2023

solved by #959

@armano2 armano2 deleted the dep/object-assign branch April 14, 2023 18:33
@coveralls
Copy link

Coverage Status

Coverage: 94.77%. Remained the same when pulling 2a1d1c9 on armano2:dep/object-assign into d0e5d59 on conventional-changelog:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmywarting jimmywarting jimmywarting approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@armano2 @coveralls @jimmywarting