Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git semver tags recognize all tags #693

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pablogm95
Copy link

This pull request resolves the #688 issue

@markudevelop
Copy link

Good job, git tag --sort=-"v:refname" list all tags properly! for me as well!

@bcoe
Copy link
Member

bcoe commented Nov 4, 2020

I think the issue with this approach would be that it returns tags across multiple branches, where as some of the libraries that rely on git-semver-tags assume that it's only returning tags that are associated with the current branch that it's running against.

This is at least my guess, as to why it was implemented in such a way.

@bcoe
Copy link
Member

bcoe commented Dec 30, 2020

@pablogm95 what if you made this an option you could pass in, so that people could opt in to listing all tags regardless of branch? or, alternatively, is there a way to tell the tag command to only run against the current branch?

@pablogm95
Copy link
Author

Hello @bcoe . Your suggestion sounds good. I'll work on it these days.

@joshuasimon-taulia
Copy link

I think the issue with this approach would be that it returns tags across multiple branches, where as some of the libraries that rely on git-semver-tags assume that it's only returning tags that are associated with the current branch that it's running against.

This is at least my guess, as to why it was implemented in such a way.

is this documented anywhere? our CI process pushes an additional commit to the tag on release which causes new tags to go undetected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants