Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conventionalcommits as changelogPreset in lerna.json leads to unwanted config update #930

Open
floydspace opened this issue Jul 2, 2022 · 0 comments · May be fixed by #931
Open

conventionalcommits as changelogPreset in lerna.json leads to unwanted config update #930

floydspace opened this issue Jul 2, 2022 · 0 comments · May be fixed by #931

Comments

@floydspace
Copy link

I use conventionalcommits as changelogPreset in my monorepo lerna.json config:

{
  "packages": [
    "packages/*"
  ],
  "version": "1.2.0",
  "command": {
    "version": {
      "allowBranch": [
        "master",
        "release/*",
        "feature/*"
      ],
      "message": "chore(release): [skip ci] publish %s"
    }
  },
  "changelogPreset": {
    "name": "conventionalcommits",
    "commitUrlFormat": "{{host}}/{{owner}}/{{repository}}/commits/{{hash}}",
    "compareUrlFormat": "{{host}}/{{owner}}/{{repository}}/compare/{{previousTag}}%0D{{currentTag}}#diff"
  }
}

But as soon as I bump a new version it mutates lerna.json with default properties set in conventional-changelog-conventionalcommits
image

I expect that version bump updates only version in lerna.json. I will raise a PR for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid config mutating with default params (fixes #930) floydspace/conventional-changelog
1 participant
@floydspace