Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(load): migrate tests from ava to jest #911

Closed
wants to merge 2 commits into from

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Jan 27, 2020

Migrate load tests from ava to jest

Description

proxyquire is dropped as in incompatible with jest, and instead i used builtin jest mocks,
for unknown reason this package was included in lint, but was used only in load,

serial test got merged with other tests (i can change that if its preferred)

How Has This Been Tested?

Unrelated

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@armano2 armano2 changed the title test(load): migrate ava tests to jest test(load): migrate tests from ava to jest Jan 27, 2020
@armano2 armano2 requested a review from byCedric January 27, 2020 19:15
@byCedric
Copy link
Member

Looks good, maybe toMatchObject would be a better replacement for deepEquals?

@marionebl
Copy link
Contributor

This is great, thanks! I incorporated the relevant changes here into #786!

@marionebl marionebl closed this Jan 27, 2020
@armano2 armano2 deleted the load-test branch January 27, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants