docs: update docs to reflect is-ignored changes #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per #595 (comment) |
byCedric
approved these changes
Apr 26, 2019
docs/reference-configuration.md
Outdated
| /* | ||
| * If this is true we will not use any of the default is-ignored rules | ||
| * Wether the default ignore rules should be used |
There was a problem hiding this comment.
I would end here with a period too since it's a sentence (and you did that for the upper one).
There was a problem hiding this comment.
I also checked it with Grammarly, it's stating that it's not Wether but Whether. But I'm Dutch and have no clue about proper spelling 馃槃
docs/reference-configuration.md
Outdated
| (commit) => commit === '' | ||
| ], | ||
| /* | ||
| * If this is true then the default ignores like `Merge commit` are not ignored | ||
| * If this is false then the default ignores like `Merge commit` are not ignored |
There was a problem hiding this comment.
Same here, I would personally end with a period too.
|
Using Grammarly is a good idea for docs texts. Rephrased the docs to be a bit easier to read. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.