Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify the parameters for the sander.readFile function (#448) #630

Merged
merged 2 commits into from
May 2, 2019
Merged

fix: modify the parameters for the sander.readFile function (#448) #630

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71509c4
fix: modify the parameters for the sander.readFile function (#448)
Apr 26, 2019
5fb8f52
fix: modify the parameters for the sander.readFile function (#448) - …
Apr 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion @commitlint/read/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ async function getEditFilePath(top, edit) {
if (dotgitStats.isDirectory()) {
editFilePath = path.join(top, '.git/COMMIT_EDITMSG');
} else {
const gitFile = await sander.readFile(dotgitPath, 'utf8');
const gitFile = await sander.readFile(dotgitPath, { encoding: 'utf-8' });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier seems to want to format this differently, could you apply it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marionebl,
Done, can u help to do the code review again, please?
This is my first MR, if there was any other thing needed to be done, please let me know.
Thx~

const relativeGitPath = gitFile.replace('gitdir: ', '').replace('\n', '');
editFilePath = path.resolve(top, relativeGitPath, 'COMMIT_EDITMSG');
}
Expand Down