feat(cz-commitlint): add emoji to title #3618
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an emoji in the title of the questions referring to the type of commit
|
@parloti thanks! Any chance you can add a test for this? |
Hi! |
curly210102
reviewed
Jun 19, 2023
| enumList = enumRuleList | ||
| .sort((a, b) => enumNames.indexOf(a) - enumNames.indexOf(b)) | ||
| .map((enumName) => { | ||
| const enumDescription = enumDescriptions[enumName]?.description; | ||
| if (enumDescription) { | ||
| const emoji = enumDescriptions[enumName]?.emoji; | ||
| const prefix = emoji ? emoji + ' ' : ''; |
There was a problem hiding this comment.
Due to the different number of characters in the composition of Emoji, it is necessary to determine the longest one and perform space alignment processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an emoji in the title of the questions referring to the type of commit
Motivation and Context
Although emojis are already configured in config-conventional they are not used in cz-commitlint
TODO emoji + title
Usage examples
No need for configuration
How Has This Been Tested?
Tested in private repository
Types of changes
Checklist: