Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop truncating the body in presence of dashes #3476

Commits on Jan 3, 2023

  1. Copy the full SHA
    0e35cd0 View commit details
    Browse the repository at this point in the history
  2. fix: stop truncating the body in presence of dashes

    In the current version of commitlint the body is truncated
    unexpectedly when there is a pattern like
    '- Something between dashes -' in the commit message body.
    The reason for this behavior is that in the commit parser
    package the commitlint uses (conventional-commit-parser[1]),
    this pattern '- something -' is a special pattern for any
    arbitrary filed. For example, if you put '-myNote-' in the
    commit message body, everything that comes after this field
    will be saved in an arbitrary field called myNote (Or
    whatever is written between dashes) and you can use it like
    other fields (header, body, etc.), but I believe we should
    disable this functionality because, in the commit messages
    like the one in the bug report that this commit fixes, the
    user might put stack trace in the commit message body and
    this way it will be truncated unexpectedly.
    
    Fixes conventional-changelog#3428
    
    [1] https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-commits-parser/README.md
    tehraninasab committed Jan 3, 2023
    Copy the full SHA
    d6efdfa View commit details
    Browse the repository at this point in the history