Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Expand lerna version range to accept v6 #3417

Merged
merged 1 commit into from Nov 1, 2022
Merged

build: Expand lerna version range to accept v6 #3417

merged 1 commit into from Nov 1, 2022

Conversation

JaneJeon
Copy link
Contributor

@JaneJeon JaneJeon commented Oct 31, 2022

See #3409.

Even with the peerDependencies: optional, npm will still kick and scream and end your process if you try to use this with lerna v6.

Note that this is NOT a breaking change - and simply allows people with lerna v6 to work with the package. People on lerna v5 will not even notice the difference.

Description

Allows this package to work with lerna v6

Motivation and Context

See above

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

See #3409.

Even with the peerDependencies: optional, npm will *still* kick and scream and end your process if you try to use this with lerna v6.
@escapedcat
Copy link
Member

npm will still kick and scream

:D That's what it does. Thanks for the PR! Will do a release.

@escapedcat escapedcat merged commit 6a19aa1 into conventional-changelog:master Nov 1, 2022
@JaneJeon JaneJeon deleted the patch-1 branch November 1, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants