Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: husky add .husky/commit-msg docs fix #3113

Merged
merged 2 commits into from Apr 23, 2022
Merged

docs: husky add .husky/commit-msg docs fix #3113

merged 2 commits into from Apr 23, 2022

Commits on Apr 22, 2022

  1. docs: husky add .husky/commit-msg docs fix 

    Executing

```

npx husky add .husky/commit-msg 'npx --no -- commitlint --edit $1'
yarn husky add .husky/commit-msg 'yarn commitlint --edit $1'

```

doesn't seem to produce desired .husky/commit-msg file content

```
. "$(dirname "$0")/_/husky.sh"

npx --no -- commitlint --edit $1
```

instead it produces

```
. "$(dirname "$0")/_/husky.sh"

npx --no -- commitlint --edit
```

because $1 is interpolated, adding slash doesn't seem to help, hence suggested fix (fix is bit ugly I admit, up to you guys to accept it or fixing it your way)
    @sdzialowski-godaddy @escapedcat
    sdzialowski-godaddy authored and escapedcat committed Apr 22, 2022
    Copy the full SHA
    fc4827a View commit details
    Browse the repository at this point in the history

  2. docs: linting

    @escapedcat
    escapedcat committed Apr 22, 2022
    Copy the full SHA
    bd270bf View commit details
    Browse the repository at this point in the history