Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring node_modules folders inside nested workspaces as Lerna scopes #3025

Merged
merged 2 commits into from Feb 14, 2022
Merged

Ignoring node_modules folders inside nested workspaces as Lerna scopes #3025

merged 2 commits into from Feb 14, 2022

Conversation

emredoganm
Copy link
Contributor

Description

For nested workspaces, the config rules also gave the name of the packages' dependencies as Lerna scope.

Motivation and Context

The issue of #3023

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Member

Thanks @emredoganm ! Awesome!

@escapedcat escapedcat merged commit e597735 into conventional-changelog:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants