Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnnotationAttributeDualReader that can read both annotations and attributes at the same time #165

Merged
merged 8 commits into from
Jul 12, 2021

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Jul 8, 2021

I'm testing the practise in practise and it seems the DualReader can only read annotation or attributes, not both at the same time.

That's why method like this fails:

	/**
	 * @RequestParameters({
	 *     @RequestParameter(in="path", type="int", name="userId", description="User ID"),
	 * })
	 */
	#[Path(path: '/user/{userId}/collections')]
	public function run()
	{
	}

@TomasVotruba TomasVotruba changed the title tv in path combo Add AnnotationAttributeDualReader that can read both annotations and attributes at the same teime Jul 8, 2021
@TomasVotruba TomasVotruba changed the title Add AnnotationAttributeDualReader that can read both annotations and attributes at the same teime Add AnnotationAttributeDualReader that can read both annotations and attributes at the same time Jul 8, 2021
@TomasVotruba
Copy link
Contributor Author

Ready to merge 👍

@TomasVotruba
Copy link
Contributor Author

There is one more bug with doctrine/annotations... 🤔 I'm just looking into it

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@TomasVotruba
Copy link
Contributor Author

I've updated version to use tag, now up and CI running succesfuly 🎉

Ready to merge ✔️

@f3l1x f3l1x merged commit 7e15641 into contributte:master Jul 12, 2021
@TomasVotruba TomasVotruba deleted the tv-in-path-combo branch July 12, 2021 14:14
@TomasVotruba
Copy link
Contributor Author

Just curious, our project avoid dev deps to speedup compose installations on CI and make dependencies more reliable. When do you plan to release this feature?

@f3l1x
Copy link
Member

f3l1x commented Jul 14, 2021

I will call you on the phone. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants