Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent rendering 0 if no content in <footer /> #249

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anna-liepina
Copy link

Purpose of PR

  • prevent render 0 is content is empty

Purpose

when I started to work on my side project, I noticed it renders 0 if you remove all links from footer

Deployment & Risks

  • There is a migration necessary for this to work
  • There is a dependent PR that needs to be deployed first
  • I have read the relevant readme.md file(s)
  • Tests are added/updated/not required
  • Tests are passing
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

Security

Before you click Merge, take a step back and think how someone could break the Confidentiality, Integrity and Availability of the code you've just written. Are secrets secret? Is there any sensitive information disclosed in logs or error messages? How does your code ensure that information is accurate, complete and protected from modification? Will your code keep Contentful working and functioning?

P.S. can I get in contentful t-shirt? :P

Signed-off-by: Anna Liepina <47822694+anna-liepina@users.noreply.github.com>
@anna-liepina anna-liepina requested a review from a team as a code owner January 15, 2024 17:16
Copy link

vercel bot commented Jan 15, 2024

@anna-liepina is attempting to deploy a commit to the Contentful Apps Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant