Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Transifex app remove the default locale restriction #1784

Merged
merged 1 commit into from May 20, 2024

Conversation

foteinigk
Copy link
Contributor

Purpose

Remove the check for contentful space default locale match with transifex project source language, since they can be different now

Approach

Testing steps

Try to connect a transifex project with source language different from contentful space's default locale

Breaking Changes

Dependencies and/or References

Deployment

@foteinigk foteinigk requested review from a team as code owners May 9, 2024 12:46
@foteinigk
Copy link
Contributor Author

Hi @jsdalton ! Could you also check this PR at your convenience? We have already tested it internally. And regarding this PR it seems that we are not having the permissions to merge. Thanks a lot in advance🙏

@mkiousi
Copy link

mkiousi commented May 17, 2024

Hello from Transifex! Is there an ETA on when the Contentful team will review this PR?

@lilbitner lilbitner added this pull request to the merge queue May 20, 2024
Merged via the queue into contentful:main with commit e438d59 May 20, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants