feat: Xillio Transcreate App #1318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ghuisma! Thank you for opening this PR, there are just a couple of things that need to be addressed:
|
Co-authored-by: Matthew Gordon <m.gordon5525@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
This is the source code for the HelloTranslate app.
We currently have a monorepo setup with a shared package containing Zod schemas and the corresponding TypeScript types inferred from those, which we're using in both our backend and frontend. Well, it turns out this doesn't work very well with your MPA repo/setup. 馃う
For now, I manually included the shared type declarations in
/types. I'll work out a more elegant solution for that in the future. Quite possibly this would involve publishing the type declarations on NPM. But we might also come up with a different solution. Anyway, that's very much an "us" problem and not a "you" problem. We'll figure something out. 馃挭If there's anything in this PR that's missing or not up to standard, please let me know, and I will fix it ASAP.
Thanks! 鉂わ笍