refactor: fetch all references with includes #522

dimitrycf · 2024-03-25T13:47:08Z

Purpose

refactor recursion
- clearly state destination variables (responseItems, responseAssetsFromIncludes , responseEntriesFromIncludes)
- make explicit gathering of: responseItems, responseAssetsFromIncludes , responseEntriesFromIncludes
explicitly state TS types
- also fixes unnecessary returning of includes{}
make downsizing of the LIMIT explicit
add deduplication of gathered Assets and Entries
ensure that includes.Assets and includes.Entries are aggregated on pages 2 and beyond

… Asst&Ent aggrgate frm pags 2+

vercel · 2024-03-25T13:47:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
experience-builder-test-app	✅ Ready (Inspect)	Visit Preview	Mar 25, 2024 3:38pm

Chidinma orajiaku and others added 9 commits March 19, 2024 13:25

fix: fetch all references

5af2b62

chore: add tests

3dbc20a

fix: failing tests

835b39b

fix: failing tests

bc877b6

fix: failing tests

c19adfa

fix: correct return when response is undefined

d785366

feat: fetch all references with includes

97366e5

fix: lint issue

fcf40a8

fix: refactor recrsion, explict types, dwnsize LIMIT explicit, dedupe…

e7a90a8

… Asst&Ent aggrgate frm pags 2+

dimitrycf requested review from a team as code owners March 25, 2024 13:47

dimitrycf mentioned this pull request Mar 25, 2024

fix: fetch all references with includes #519

Merged

fix: rename filenames to wire file into tests

ef6d2ca

vercel bot deployed to Preview March 25, 2024 13:54 View deployment

dimitrycf added 2 commits March 25, 2024 15:35

fix: default limit

57ac9c0

fix: make test mocks have correct number of entries (eg. 100 total)

235f7c7

vercel bot deployed to Preview March 25, 2024 15:38 View deployment