fix(rate-limit): do not store instances/defaultconfigs globally #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makinwab
approved these changes
Apr 24, 2020
|
🎉 This PR is included in version 6.4.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this global map of httpclient instances -> default configs was necessary because of a bug in Axios 19.0 (The change to to SDK-core was added here). This bug was fixed in axios, so it's no longer necessary (axios/axios#2207).
We suspect this may be causing a memory leak, since this memory is never released.
Testing with the-example-app.nodejs locally, this change did improve the jsheapsize after garbage collection, so hopefully this helps our customers, too.