Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: major axios version bump to 1.x [NONE] #362

Merged
merged 2 commits into from Jul 17, 2023

Conversation

marcolink
Copy link
Member

@marcolink marcolink commented Jun 22, 2023

This is a major version bump of the core dependency axios. It most likely introduces breaking type changes.

For Reference

BREAKING CHANGE: bump axios to 1.x

@marcolink marcolink requested a review from a team as a code owner June 22, 2023 10:13
@@ -114,3 +116,13 @@ export type CreateHttpClientParams = {
*/
attempt?: number
}

export type ContentfulErrorData = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice change

Copy link
Contributor

@andreascful andreascful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change! 👍

@marcolink marcolink merged commit b746440 into master Jul 17, 2023
2 checks passed
@marcolink marcolink deleted the feat/bump-axios-to-1.x branch July 17, 2023 12:49
@contentful-automation
Copy link

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants