Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities/field-type): correct casing of resourcelink array item types #2279

Merged
merged 1 commit into from
May 16, 2024

Conversation

cysp
Copy link
Contributor

@cysp cysp commented May 16, 2024

Summary

Correct typing of arrays containing resource link items

Description

The typings exposed for arrays containing resource link items appear to be incorrect, using the casing Resourcelink where all other documentation and examples capitalise the l like ResourceLink

Motivation and Context

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

When adding a new method:

  • The new method is exported through the default and plain CMA client
  • All new public types are exported from ./lib/export-types.ts
  • Added a unit test for the new method
  • Added an integration test for the new method
  • The new method is added to the documentation

@cysp cysp requested a review from a team as a code owner May 16, 2024 01:10
Copy link
Contributor

@mgoudy91 mgoudy91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks for the contribution!

@mgoudy91 mgoudy91 enabled auto-merge (squash) May 16, 2024 17:09
@mgoudy91 mgoudy91 merged commit 1b5433c into contentful:master May 16, 2024
3 checks passed
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.25.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants