feat: add archivedAt property type to SpaceProps [] #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`space.sys.archivedAt` does exist when the space was archived. This PR adds the type for that property to the SpaceProps.
mgoudy91
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
space.sys.archivedAtdoes exist when the space was archived.Description
This PR adds the type for that property to the SpaceProps.
Motivation and Context
We need to be able to check
archivedAtto filter out spaces that are archived as any requests for those spaces will result in 404 responses from the API which we want to avoid.Checklist (check all before merging)