build(react18)!: drop support for react v16 and v17 #7666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecommerce-app-base-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ethan-ozelius-contentful
force-pushed
the
eozelius/ecommerce-app-base/react-sortable-hoc-to-dndkit
branch
6 times, most recently
from
015e939
to
c1e5270
Compare
packages/ecommerce-app-base/src/ProductCard/ProductImage/ProductImage.tsx
Show resolved
Hide resolved
packages/ecommerce-app-base/src/Editor/SortableComponent.stories.tsx
Outdated
Show resolved
Hide resolved
| skuType, | ||
| }) => { | ||
| const [productPreviews, setProductPreviews] = useState<Product[]>([]); | ||
| const getProductPreviews = useCallback(async () => { |
There was a problem hiding this comment.
- todo: see if we can re-implement
shouldRefetch()
There was a problem hiding this comment.
done, see usePreviousSkus() hook
ethan-ozelius-contentful
force-pushed
the
eozelius/ecommerce-app-base/react-sortable-hoc-to-dndkit
branch
4 times, most recently
from
29bbcbe
to
6090fc6
Compare
ethan-ozelius-contentful
changed the title
ethan-ozelius-contentful
changed the title
…rtable-hoc with dnd-kit BREAKING CHANGE: Consumers of ecommerce-app-base are required to implement react v18
ethan-ozelius-contentful
force-pushed
the
eozelius/ecommerce-app-base/react-sortable-hoc-to-dndkit
branch
from
6090fc6
to
61327d5
Compare
whitelisab
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
react v16 >=react-sortable-hoclibrary with new dndkit that supports react v18 <=BREAKING CHANGE: Dropping support for
react-dom <= 17andreact <= 17. Consumers of ecommerce-app-base are required to implement react v18.Testing steps
Shopify
Tested locally by
npm pack'ing aecommerce-app-basetar file, and installing it locally inside shopify.Also tested with Storybook