(MINOR) Update xmp_toolkit to v1.7.1, remove Ring dependency, fix build errors
#407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
=======================================
Coverage 79.93% 79.93%
=======================================
Files 80 79 -1
Lines 24240 24241 +1
=======================================
+ Hits 19377 19378 +1
Misses 4863 4863 ☔ View full report in Codecov by Sentry. |
dkozma
changed the title
xmp_toolkit to v1.7.1 to resolve build issuexmp_toolkit to v1.7.1, remove Ring dependency, fix build errors
dkozma
force-pushed
the
update-xmp-toolkit
branch
from
bc7ef41
to
f147d80
Compare
dkozma
changed the title
xmp_toolkit to v1.7.1, remove Ring dependency, fix build errorsxmp_toolkit to v1.7.1, remove Ring dependency, fix build errors
dkozma
force-pushed
the
update-xmp-toolkit
branch
from
ad73e2b
to
b8f99bf
Compare
scouten-adobe
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
xmp_toolkitto v1.7.1 to resolve a build issue stemming from a new version of thecccrate (discussed in this issue).ringsince we were just using it for secure random number generation and it was causing a good deal of cross-compilation issues. This replaces it withCrypto.getRandomValues()in Wasm and the ChaCha20Rng in systems not running OpenSSL.Updates the usage ofHad to pin toread_fromtoread_from2due to this change in theid3crate.id3@=1.12.0due to Rust 1.70 compatibility issues that undid this change.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.