Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all of the MIME types that are associated with WAV files #316

Merged
merged 1 commit into from Oct 4, 2023

Conversation

dkozma
Copy link
Contributor

@dkozma dkozma commented Oct 4, 2023

Overview

This was causing browser integrations to fail based on the detected MIME type for WAV files.

Changes in this pull request

  • Associate audio/wav, audio/x-wav, audio/wave and audio/vnd.wave as valid WAV MIME types based on this comment.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f5492d4) 78.98% compared to head (eb64dc6) 78.98%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   78.98%   78.98%           
=======================================
  Files          79       79           
  Lines       23350    23350           
=======================================
  Hits        18442    18442           
  Misses       4908     4908           
Files Coverage Δ
sdk/src/asset_handlers/riff_io.rs 89.81% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mauricefisher64 mauricefisher64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dkozma dkozma merged commit 50729b7 into main Oct 4, 2023
23 checks passed
@dkozma dkozma deleted the dkozma/add-wav-mime-type branch October 4, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants