Fixes 143: Remove null fields from api responses #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rverdile
force-pushed
the
bulk-create-error
branch
from
8d9b917
to
018dd38
Compare
rverdile
commented
Aug 24, 2022
rverdile
commented
Aug 24, 2022
| @@ -62,7 +62,7 @@ func (rc *RepositoryConfiguration) BeforeUpdate(tx *gorm.DB) (err error) { | |||
|
|
|||
| func (rc *RepositoryConfiguration) DedupeVersions(tx *gorm.DB) (err error) { | |||
| var versionMap = make(map[string]bool) | |||
| var unique []string | |||
| var unique = make(pq.StringArray, 0) | |||
There was a problem hiding this comment.
this prevents distribution versions from returning null
rverdile
changed the title
rverdile
force-pushed
the
bulk-create-error
branch
from
018dd38
to
64761b7
Compare
|
Hi Rebase please. the ci.int.devshift check for this PR only failed on |
|
Because this contains openapi spec changes, we won't see the test pass in CI - the client generation is not dynamic. @swadeley can pull the openapi spec into our plugin ahead of merging this once we're confident in the content (above discussions about scope of nil values resolved). |
rverdile
force-pushed
the
bulk-create-error
branch
from
64761b7
to
94123bf
Compare
|
this needs a rebase. |
rverdile
force-pushed
the
bulk-create-error
branch
from
94123bf
to
6a42afe
Compare
|
/retest |
rverdile
force-pushed
the
bulk-create-error
branch
from
6a42afe
to
4b7edb2
Compare
rverdile
force-pushed
the
bulk-create-error
branch
2 times, most recently
from
9acef8b
to
bf17beb
Compare
rverdile
force-pushed
the
bulk-create-error
branch
from
bf17beb
to
ea82183
Compare
|
failure looks unrelated: swaggo/swag#1309 |
jlsherrill
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three fields I could find that were returning null:
2. The bulk create repository field, when there is an error.leaving out because it's not causing a CI failure and it's not a simple fixI changed these to:
2. empty object