Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] Auto-clear the session form data #1550

Merged
merged 2 commits into from Jun 11, 2018
Merged

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Jun 9, 2018

See #1389.

@leofeyer leofeyer added this to the 4.6.0 milestone Jun 9, 2018
@leofeyer leofeyer self-assigned this Jun 9, 2018
contao.listener.clear_form_data:
class: Contao\CoreBundle\EventListener\ClearFormDataListener
tags:
# The priority must be lower than the one of the Symfony save session listener (defaults to -1000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the priority must be higher than...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 6847201.

@leofeyer leofeyer changed the title [WIP] Auto-clear the session form data [RTM] Auto-clear the session form data Jun 11, 2018
@leofeyer leofeyer requested review from Toflar and aschempp June 11, 2018 10:02
@aschempp
Copy link
Member

To make it all work, do we need to start the session when form data is submitted and actually store the data?

@leofeyer
Copy link
Member Author

Right now the session is started automatically thanks to our LazySessionAccess class. And since using $_SESSION is deprecated anyway, I would leave it this way.

@leofeyer leofeyer merged commit 1134405 into master Jun 11, 2018
@leofeyer leofeyer deleted the feature/clear-form-data branch June 11, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants